Handle basic query parameters in connection URI #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| for (String param : rawQuery.split("&")) { | ||
| String[] pair = param.split("="); | ||
| String key = URLDecoder.decode(pair[0], "US-ASCII"); |
There was a problem hiding this comment.
Any reason to not use UTF-8 here?
There was a problem hiding this comment.
I used the same charset as in uriDecode line 378, which is used to decode username password and vhost.
private static String uriDecode(String s) {
try {
// URLDecode decodes '+' to a space, as for
// form encoding. So protect plus signs.
return URLDecoder.decode(s.replace("+", "%2B"), "US-ASCII");
}
catch (IOException e) {
throw new RuntimeException(e);
}
}
|
@acogoluegnes FYI, I discussed this with @captainju on Slack and suggested that we would consider such a contribution. |
|
Thanks! |
acogoluegnes
added a commit
that referenced
this pull request
Feb 22, 2021
With fallback hook, by default empty. References #672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The current connection method
setUri()does not handle query parameters at all, unlike the official Erlang client.This pull request adds basic query parameters capabilities.
However, due to SSL handling differences between the Erlang client and the Java client, all SSL parameters are not used.
Only the following parameters are used:
(taken from https://www.rabbitmq.com/uri-query-parameters.html)
It is easily extendable for other future query parameters.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocument